Se7enZ
Se7enZ
Thanks! It had almost slipped on me as well. I've submitted a plea for inclusion over Discord.
> So the symptom appears to be a missing teardown of some fixtures in case of an error? Actually, the FDs stick around even if the test passed successfully. `lsof`...
Updated issue description for clarity by removing references to earlier prototype code cross-referenced in https://github.com/ElementsProject/lightning/pull/7108#issuecomment-1981399218 and describing test results.
The build failures appear to be in different place each time, and should not be related to my changes, so I assume they are inherited in CI build failures bubbling...
Some reformatting of the commands and minor syntactical optimizations.
Removed modifications to the `CHANGELOG.md` and opted for a `Changelog-None` hint in the commit message. Users probably don't care about all the CI processes...
@ShahanaFarooqui Thanks for having a look! I'll address at your change requests as soon as I can, but it might take some time. As your question on testing is important,...
@ShahanaFarooqui I tried to reproduce the `-modded` build locally using my [7117-repro-nightly-builds-test](https://github.com/ElementsProject/lightning/compare/master...s373nZ:lightning:7117-repro-nightly-builds-test) branch which contains `21fcd45` reverted using the [Reproducible builds](https://docs.corelightning.org/docs/repro) documentation, but it didn't produce a `-modded` build for...
Apologies in advance for the looooooong comment. > I pulled your branch s373nZ:7117-repro-nightly-builds and it is generating the -modded build locally with below steps... I followed the steps you describe...
Now that we agree on the difference between the commit hash and the `-modded` appearing in the `VERSION`, Shahana explained more about the release process. I need to explore that...