ReGameDLL_CS icon indicating copy to clipboard operation
ReGameDLL_CS copied to clipboard

[feature request] mp_hegrenade_penetration should be renamed

Open rust2 opened this issue 2 years ago • 5 comments

as written in game.cfg:

// Disable grenade damage through walls
// 0 - disabled
// 1 - enabled
//
// Default value: "0"
mp_hegrenade_penetration 0

IMHO cVar name should be changed to mp_hegrenade_penetration_disable or something like that, and it is confusing me because when i see mp_hegrenade_penetration 1 I think grenades will deal damage to me. But it is opposite

rust2 avatar Mar 22 '22 19:03 rust2

That is pretty clear. Disable grenade damage through walls ?

0 - function disabled
1 - function enabled

ShadowsAdi avatar Mar 22 '22 19:03 ShadowsAdi

That is pretty clear.

I learned it only when checked cfg.

But cvar name should be self explaining IMHO.

Like if mp_hegrenade_penetration 1 then grenade will penetrate, if mp_hegrenade_penetration 0 then not. Seems logical for me.

rust2 avatar Mar 22 '22 19:03 rust2

Yes, CVar name is illogical. Feature in-game should be swapped if name is kept.

StevenKal avatar Mar 23 '22 01:03 StevenKal

bad idea to touch it as it will break plugins that use this cvar

Giferns avatar Mar 23 '22 02:03 Giferns

Is really there plugins relying on it (like for a custom damage radius code)? In such case renaming the CVar will also break such plugins. In overal, changing just its internal behavior (swap) will break more the gameplay behavior until the admins change the CVar to the other value.

StevenKal avatar Mar 23 '22 14:03 StevenKal