Sanskar Modi comments

Results 40 comments of


                                            Sanskar Modi

[CELEBORN-1550] Add support of providing custom dynamic store backend implementation

@AngersZhuuuu Updated the doc.

[CELEBORN-1550] Add support of providing custom dynamic store backend implementation

@SteNicholas Added. Q: do you want me to make use of it in this PR?

[CELEBORN-1550] Add support of providing custom dynamic store backend implementation

> the implementation of ConfigService could use getName interface to load the implementation instance instead of hard code in factory. @SteNicholas Trying to understand this comment better – I think...

[CELEBORN-1536] Add option to toggle between human friendly vs single line logging

@SteNicholas @waitinfuture @pan3793 wdyt about this change. We can fix this at more places incrementally.

[CELEBORN-1536] Add option to toggle between human friendly vs single line logging

@SteNicholas @waitinfuture ping for this ^

[CELEBORN-1536] Add option to toggle between human friendly vs single line logging

@FMX this mainly aims to improve the Master and Worker logging. If i want to keep such logs but don't want it in human readable way to avoid new lines.

[CELEBORN-1617][CIP-11] Support workers tags in FS Config Service

I've made tags part of SystemConfig as it made more sense to me, let me know if you think if it should extracted out as a separate config something like...

[CELEBORN-1617][CIP-11] Support workers tags in FS Config Service

ping @FMX @zwangsheng @mridulm

[CELEBORN-1582] Publish metric for unreleased shuffle count when worker was decommissioned

@SteNicholas We're currently not in production but this will help us tune the forceExitTimeout config better and see if the default value is working for us or not. As we...

[CELEBORN-1582] Publish metric for unreleased shuffle count when worker was decommissioned

Sorry messed up the commit history on this one, reopening the PR again. @SteNicholas updated the PR with dashboard changes.