Photon
Photon copied to clipboard
Potential dependency conflicts between Photon and urllib3
Hi, as shown in the following full dependency graph of Photon, Photon requires urllib3 (the latest version), while the installed version of requests(2.22.0) requires urllib3>=1.21.1,<1.26.
According to Pip's “first found wins” installation strategy, urllib3 1.25.3 is the actually installed version.
Although the first found package version urllib3 1.25.3 just satisfies the later dependency constraint (urllib3>=1.21.1,<1.26), it will lead to a build failure once developers release a newer version of urllib3 in the near future, which is greater than 1.26.
Dependency tree--------
Photon(version range:)
| +-requests(version range:)
| | +-chardet(version range:>=3.0.2,<3.1.0)
| | +-idna(version range:>=2.5,<2.9)
| | +-urllib3(version range:>=1.21.1,<1.26)
| | +-certifi(version range:>=2017.4.17)
| +-tld(version range:)
| +-urllib3(version range:)
Thanks for your attention. Best, Neolith
Solution
-
Fix your direct dependencies to be urllib3>=1.21.1,<1.26 and requests==2.22.0, to remove this conflict. I have checked this revision will not affect your downstream projects now.
-
Remove your direct dependency urllib3, and use the library urllib3 transitively introduced by requests.
@s0md3v Please let me know your choice. I can submit a PR to fix this issue.