office-ui-fabric-vue
office-ui-fabric-vue copied to clipboard
Added Modal Component
Added modal with popup branch merged
- [ ]
isClickableOutsideFocusTrapandisBlockingis redundant. It's only included in the react library due to the common interfaceIAccessiblePopupProps. Let's just keepisBlockingand remove the other one. - [ ] Closing animation missing
- [ ] Unable to close popup by clicking outside of it
- [ ] Don't use function props like
onDismiss. Use an event! (``$emit("dismiss")`) - [ ] You removed
containerClassNameandscrollableContentClassNameand therefore lost the functionality to style the inner components. That's why you need these uglyflexandcenterproperties. Get rid of them and add back the two...ClassNameproperties! - [ ] The
FocusTrapZoneis missing a:class="classNames.main". Also the custom style is wrong, as theFocusTrapZoneshould not be 100% height and width. Compare with https://developer.microsoft.com/en-us/fabric#/components/modal - [ ] OfficeOverlay has a "visible" property now, which you did not set, so it's always false.
- [ ] Your
stateproperty makes no sense. A state can never be a getter only! Just use normal class fields for that kind of stuff