Arash Sahebolamri
Arash Sahebolamri
You are correct! I need to merge the `byods` branch before fixing formatting issues. I don't think I'll switch to the default rustfmt config though.
@mkatychev Thanks for the suggestion. I'll get it once I get a chance to merge the BYODS work.
Hmm, do you have a concrete use case where this is an issue? I don't think the guideline applies here, for a number of reasons: - The bounds are specified...
> Update: support for aforementioned syntax has now been implemented on the PR: https://github.com/s-arash/ascent/pull/25#issuecomment-1858441698 I definitely prefer this approach to shifting the user's defined generic bounds to the impl block....
> But either way behavioral trait bounds should never be added to the type declaration as outlined above. Even assuming I agree with this completely (I'm not sure I do....
Hi @regexident, and thanks again for the PR! Do you have time to fix the remaining errors in this PR? If not, let me know and I can take it...
> The handling of attritibute parsing within impl Parse for AscentProgram { … } looks a bit shady to me (leaky abstraction) since any changes within Signatures should not break...
Hi @regexident. I think checking for the exact expansion output is not the right way to test Ascent, since the exact output can change quite frequently. What should be tested...
Thanks for bringing up the issue! I'll either follow your suggestion and use `replace_with` instead of `update`, or change impls of `Lattice` to not need to call `update` at all.
My use case is the first case (parse the last variant if all the `#[peek(..)]`s fail). I realized that I could use `#[peek_with(|_| true, ...)]` to achieve the effect I...