Sebastian Schaper

Results 35 comments of Sebastian Schaper

Commits should be squashed into a single commit per device, in this case the dtsi split and actual adding of DIR-869 might be separated though. Things like increasing the spi...

Built and tested on DIR-869, works fine so far :slightly_smiling_face: LED behaviour is a little awkward with both configured to WAN activity, but this is consistent with ar71xx. Speaking of...

I think the order of LED migration parameters is reversed here, it looks like the old value (`:status`) should belong on the left, the new one (`:power`) to the right...

First commit needs a signoff as well. Looks like a vim .swp file sneaked into the second commit (I guess that's why people keep saying not to use `git add...

As mentioned earlier, this device was supported in ar71xx already, thus the LED migration: > LED behaviour is a little awkward with both configured to WAN activity, but this is...

> Apart from that, what is the reason for renaming status->power? Most probably that DIR-842 / 859 served as a reference for similar ath79 devices here, as well as others...

``` Do not turn off the device after starting OpenWrt for the first time. Otherwise, u-boot will go into safe mode because the firmware checksum has changed. After sysupgrade, u-boot...

> I also added DIR-859 I'm not sure if this is still necessary for that device, although I only recall flashing one of these some time ago, and I think...

> There is still no justification at all for the reset-gpios change ... The boards for DIR-842 Rev. C / DIR-859 / DIR-869 are all based on the same layout...

> Same would be helpful for the SPI frequency change, but that's less dramatic ... Weird, this change has actually been in master since April (328546e1088d5b559eddd40a03318bef07f47c92). @honza96 please rebase! //...