Ray Zane
Ray Zane
I'm so sorry. I never saw the notification for this PR.
Please don't forget to run the Active Record test suite against this PR. There will be _plenty_ of failures, but it should indicate regressions.
Similar: https://github.com/promptworks/guardian_trackable
Yeah, this issue only affects Active Record 5.2. In 5.2, the query will be missing the `AND "notes"."notable_type" = 'Person'` bit, which is very important for polymorphic associations. This is...
Fixed in https://github.com/Betterment/uncruft/pull/38
I managed to make a script that occasionally reproduces the issue. https://gist.github.com/rzane/a4efe24db7ce44491f0ec6056ac16401
Note: The reason these pending requests aren't marked as `#finished?` is because the subscriptions that handle responses only assign properties to `select(request_id).last` https://github.com/rubycdp/ferrum/blob/5ca5e9ed5e9ac8be580589e234aadc1de6929bc0/lib/ferrum/network.rb#L395-L445
I would love to have this functionality. Would you be willing to take a stab at this?
I needed a memoization tool that worked with Sorbet, so I wrote this: https://github.com/rzane/memosa.
In case anyone is looking for a memoization gem that works with Sorbet, I wrote this: https://github.com/rzane/memosa.