Lime-3DS-Emulator
Lime-3DS-Emulator copied to clipboard
ryzendew
Rebrand: Replace remaining Citra references with Lime3DS
OK, here's my pass to complete the rebranding. The only thing I didn't touch was the web links because I didn't know where to point them to instead, although I did take the liberty to add more Wayback Machine links where applicable.
Edit: Hmm, not sure how to fix the lime-license error; don't know where it's pulling the src/android/app/src/main/java/io/github/lime3ds/android/CitraApplication.kt reference from so it can be renamed, but the file exists as Lime3DSApplication.kt in that directory.
Edit 2: Oops, didn't notice it touched dist/compatability_list/compatability_list.json. If that's maintained somewhere else, they may need to be synced (still seems to work, though).
Hmm, not sure how to fix the lime-license error;
Ah, it's likely because I forgot to check that the changed file actually still exists. 🙃 Easy oversight and simple fix, I'll address it tomorrow.
I have now fixed the issue with the license header checker, although given the nature of this PR, I think it's safe to say the changes it is suggesting can be wholely ignored. When this is ready for merging, the license requirement will be bypassed.
I have now fixed the issue with the license header checker, although given the nature of this PR, I think it's safe to say the changes it is suggesting can be wholely ignored. When this is ready for merging, the license requirement will be bypassed.
when i look at the details of the failed ci job it shows 1148 files with no license header. Should we check some of those files? Or is it just the checker being weird.
when i look at the details of the failed ci job it shows 1148 files with no license header. Should we check some of those files? Or is it just the checker being weird.
Observe the number of files changed in this PR; This number of files being flagged makes perfect sense. Also, the license checker is designed to find headers which need to be updated to include Lime3DS attribution, not files with a missing header.
Do you know what dist/scripting/citra.py does? I've never seen what it's used for.
Edit: After briefly checking online, it appears to be something used as an interface by users to interact with games programmatically using Python scripts. To avoid breaking any existing scripts, I will revert the changes in this file.