Ryan Thorpe comments

Results 149 comments of


                                            Ryan Thorpe

remove legacy drive conventions and functions

Nope.

remove legacy drive conventions and functions

Any residual issue(s) were addressed in #431.

Internal data containers and saving simulation results to disk

+1 for the last example. It's the most intuitive to me.

Internal data containers and saving simulation results to disk

Hey @raj1701, my email address is ryan_thorpe at brown dot edu

show how to compare HNN-core output to data

I think we've moved past this with the new GUI + tutorials. Feel free to reopen if anyone disagrees.

autapses in L5 Basket cells

I think its the other way around: L2 basket cells currently allow autapses but L5 basket cells don't. See [discussion](https://github.com/jonescompneurolab/hnn-core/pull/164/files#r486717877) in #164.

autapses in L5 Basket cells

Sure, I'll bring it up at our next meeting.

BUG: Dipole.data attribute not created when using `read_dipole()` for certain files

I'm guessing this has to do with the fact that this dipole file only has 2 columns

BUG: Dipole.data attribute not created when using `read_dipole()` for certain files

You're sure the data array used to instantiate the Dipole object has shape `(600, 1000)`? That's a huge array and somewhat surprising.... Also, @aritrasinha108 let's get your other PR completed...

BUG: Dipole.data attribute not created when using `read_dipole()` for certain files

Sure enough. I don't think I've worked with the `S1_ongoing.txt` data file before which turns out to be quite larger than the others. The problem is that the data getting...