Ryan Thorpe

Results 149 comments of Ryan Thorpe

If you're comfortable with [cherry picking](https://www.atlassian.com/git/tutorials/cherry-pick), I'd recommend branching from master and then cherry picking the single commit in #550. Then you won't have to worry about rebasing if you...

Ready for your review @jasmainak @ntolley! I ended up refactoring the network tests so that they're more unit-like while hopefully retaining all of the original logic. Since this is all...

I think this is ready to go @jasmainak @ntolley @chenghuzi if any of you want to take a look.

Just rebased to get the linkcheck to pass. Ready to mrg pending @ntolley's review.

Looks like merging @ntolley's latest PR didn't create a merge conflict... ready to go whenever you are @jasmainak @ntolley!

Is there a reason we didn't implement this before? (I feel like this came up in discussion at one point....)

> Sorry, My bad. Only `hnn_core.viz.plot_spike_raster` and `hnn_core.viz.plot_laminar_csd` are required to have a `tstop` or a `tmax`. I have added a PR for this. Could you please look into it...

I was about to close this issue, however, we seem to be having a problem getting CircleCI to pass on master. Any thoughts @chenghuzi?

No, it has something to do with the document build process for the GUI timing out. See [here](https://app.circleci.com/pipelines/github/jonescompneurolab/hnn-core/2361/workflows/3caa1e76-a782-422c-b124-c147443bfd56/jobs/2602).

I just re-discovered this issue after finishing #517. Have we moved past this or should we make the above-mentioned features + API the next PR?