Ryan Thorpe
Ryan Thorpe
I thought I had followed your directions above. Maybe I misunderstood though: ``` $ python setup.py sdist $ cd $ pip install . ```
> okay, sorry for the noise. I misunderstood what you meant by "built a source distribution" ... sdist only creates an archive Oh my bad. I though "sdist" was shorthand...
Looks good, I'm going to go ahead and merge. Thanks @jasmainak!
> You can't click on vertices yet but I'm sure it's doable :) Clicking on vertices works for me! This is super cool.
Yeah, that attribute is private for a reason ;-) Optimization doesn't touch that attribute, but rather modifies the specific drive attributes of the `Network` instance. [_get_drive_params()](https://github.com/jonescompneurolab/hnn-core/blob/3dce2f1dbdc9e7097ba9c3677da385f20d95edff/hnn_core/optimization.py#L368) was designed with the...
Nope, but the bones are there. We'll need to be thoughtful here about not recreating the whole .param file debacle as we want to provide user-facing parameters that have meaning...
One idea I pitched to @mjpelah was to allow `viz.plot_cell_morphology` to accept a `Cell` or `list of Cell` as it's first argument so that `Cell.plot_morphology` and `Network.plot_cell_morphology` are both wrappers...
> I think it's worth thinking through how the user would use the function. If you have a single function for one cell and multiple cells, how would the offsets...
Yeah, something is off. It almost looks like you rebased `master` onto your `upgrade_plot_morphology` branch instead of vice versa. @jasmainak I had advised Matt to get the logic down first,...
How's it going @mjpelah? Anything we can assist with here?