com.dufte.SimplePianoroll.xrnx icon indicating copy to clipboard operation
com.dufte.SimplePianoroll.xrnx copied to clipboard

[Enhancement] Option to remove notes not within scale

Open Lucrecious opened this issue 1 year ago • 3 comments

Thanks for the piano roll! It's amazing how clean and useful it is already.

One of the best features is the scale highlighting! It makes it really easy to play melodies.

I've seen some tutorials in some other DAWs, and their piano roll has an option to actually hide the keys not within the scale, instead of just highlighting them. Is this possible? This would be really useful for visualizing chords.

Looking at the code, it doesn't seem too difficult to do, but I could be wrong.

Great plugin!

Lucrecious avatar Dec 04 '23 15:12 Lucrecious

Hi, thank you. It should be possible, but it takes some time to implement this.

ryrun avatar Dec 04 '23 16:12 ryrun

Hi, thank you. It should be possible, but it takes some time to implement this.

I'm a programmer as well. I could be interested in implementing this myself, however, the code is a little convoluted and would take me a while to figure it out at a high level.

If you could give me a brief rundown of the high level steps for how to do this (referencing notable variables and functions), I'm down to give this a shot!

Lucrecious avatar Dec 04 '23 16:12 Lucrecious

Yep, the codebase became bigger and bigger from time to time. Started with a little test lua script. Was to lazy to do refactoring work and to split the code into multiple files etc. There are many important function: "fillPianoroll" / "handleXyPad" / ... The current codebase cant handle hidden note lanes yet, maybe with some tricks like overlapping Viewbuilder Controls with a height of "1". Need abit free time to test this.

ryrun avatar Dec 05 '23 22:12 ryrun