Ryo Onodera

Results 66 comments of Ryo Onodera

> i think this pr is small in code wise but needs careful thoughts (I'll later post such one). here it is! To be honest, I'm not super fan of...

> This branch has conflicts that must be resolved > Use the [web editor](https://github.com/solana-labs/solana/pull/34888/conflicts) or the to resolve conflicts. > Conflicting files > core/src/banking_stage/transaction_scheduler/scheduler_controller.rs seems there's still some conflicts..

> @ryoqun after merging the previously requested renames, I started rebasing this. Ended up running into several conflicts which would have created more work with original commits. So I just...

> I'll reply to the fun discussion later. this lgtm is just to unblock merging this nice pr. finally! here's the quite delayed reply from me... > @ryoqun - addressed...

@taiki-e thanks for maintaining this crate. :) i'll group my gentle reminders with this single comment. but, I'd want some initial feedback for following draft prs. if there's some hope...

@taiki-e hey, thanks for active crossbeam maintenance. could you give this pr a initial assessment whether this pr can be merge or not ever? like other my prs, I'd like...

@taiki-e > Sorry for the slow response no problem. i really thanks for replying! > I thought this was a patch that was 1k lines of complex implementation without any...

> I've just done all the above after rebased. Also marked it as ready for review. :) Thanks in advance. sorry, i pushed more to fix bugs since this comment...

@taiki-e Really and really thanks for approving this pr. Then, is this pr in a kind of internal testing now before merging? Also, do i need to add entries to...

> > is this pr in a kind of internal testing now before merging > > CI is failing on the master branch (mostly due to [rust-lang/rust#124800](https://github.com/rust-lang/rust/issues/124800)) and we need...