Nuke-WebP-Plugin icon indicating copy to clipboard operation
Nuke-WebP-Plugin copied to clipboard

Published 20 hours ago • verified publisher icon ryokosuge

I can't use this project simply by dragging into my workspace

Open drkibitz opened this issue 6 years ago • 4 comments

The copy-frameworks target fails when I am building through Xcode.

drkibitz avatar Oct 15 '18 11:10 drkibitz

I'm also realizing another issue is that it expects to have been installed by carthage before building.

Carthage allows the use of submodules, which means I expect to be able to bootstrap my project, commit things, and let other people just use git without carthage to build it.

This project breaks this pattern, but I would like to know what your thoughts on about fixing it, and if you would like to take a stab, or would like the community to take a stab? Just let me know if you can, thanks!

drkibitz avatar Oct 15 '18 19:10 drkibitz

@drkibitz Thank you for a nice suggestion! I thought about using it for my project, so I thought it would be fine if I could build with Carthage and CocoaPods.

I think I will challenge to be able to add even with drap and drop! If something troubles happens, please let me talk.

ryokosuge avatar Nov 02 '18 13:11 ryokosuge

@ryokosuge The only thing that needs to happen is removing the copy-frameworks run phase in this project. If you read the Carthage documentation for developing frameworks, it actually mentions to not include this phase for your framework. It's meant for App development.

drkibitz avatar Nov 08 '18 10:11 drkibitz

@ryokosuge can we remove the copy-frameworks step? This is causing a lot of headaches and I ended up forking it to remove it myself? I can submit a PR, but I would like some feedback before I do that?

drkibitz avatar Nov 29 '18 09:11 drkibitz