Ryo Matsukawa

Results 90 comments of Ryo Matsukawa

@jrgarciadev I've fixed it.

When merging, please close the related issue in this PR. - https://github.com/nextui-org/nextui/pull/3732

@buchananwill Sorry for the delayed review. I've left some comment, so please take a look.

This issue is a [bug in React Aria](https://github.com/adobe/react-spectrum/issues/5208). As a temporary fix, you could make the value controlled and implement the check before passing it.

> An option like `--suppressions-location` isn't provided. I believe this option is essential for Monorepo, so I’d like to include it in this release. As for the naming, since the...

@ybiquitous I agree with your proposal! - `--suppress`: applies to all rules - `--suppress=rule-name`: applies to the specified rule - `--suppress-prune`: prunes suppressions I also agree with the idea of...

@Mouvedia For consistency, I think `--suppress-location` is a better. It might also be better to align its behavior with `--cache-location`, so it accepts both a file and a directory path....

@ybiquitous @Mouvedia Cc: @jeddy3 Thanks for the feedback! I've renamed the flags and added the experimental warnings. Appreciate a review when you have time!

Waiting for https://github.com/stylelint/stylelint/pull/8600.

@ybiquitous Really appreciate all the detailed reviews! I've made the changes, so please take a look when you have a moment.