updated grammar with text

[byronbytes]

It's still being improved, but some of it sounds gramatically incorrect.

[vercel[bot]]

Someone is attempting to deploy a commit to a Personal Account owned by @ryo-ma on Vercel.

@ryo-ma first needs to authorize it.

[byronbytes]

Do not merge this PR yet, I'm still working on it

[byronbytes]

Okay I just made the final changes now it can be merged if you have any suggestions let me know

[ryo-ma]

I'm not a native English speaker. If you like, please tell me the reason for each change

[byronbytes]

Okay I just made the final changes now it can be merged if you have any suggestions let me know

That's okay! I can help

I changed the tense (Past, present, future) of the achievements since for example "High Star" doesn't make sense as an achievement, but "Many Stars" makes more sense.

I also changed Deep to Omega, since deep does not describe an achievement and doesn't make much sense.

I also changed 'god' to 'godly'

and I updated the Star category with new achievement names.

[spenserblack]

This will affect many users, and some users might not anticipate this change. I think it might be best to wait until other users have offered their opinion on this PR. (I'll try my best to also put my comments in Japanese for the sake of the repo owner)

影響される利用者が多いはずです。この変化を期待していない利用者がいるでしょう。利用者の意見をもらうまで待つ方がいいですか？

[ryo-ma]

@spenserblack What do you think of each change?

[spenserblack]

It's mostly good to me, but I'm curious about the word "Omega" for overseas cultures. What do they think of "Omega"? "Omega" is somewhat common in America. I'm not sure why "Super Star" was changed into "Little Stargazer". Why not "Super Stargazer"? I think that the meanings of "Numerous", "Many", and "Multiple" aren't too different. Words that are more different might be better. Maybe words like "galactic"?

これは私の個人的な意見です。大部分がいいと思います。でも、外国人にとって「OMEGA」とはどうでしょうか。明らかな意味ですか？アメリカには「OMEGA」は少し通用です。 さらに、「SUPER STAR」は「LITTLE STARGAZER」に代えるのはなぜですか。「SUPER STARGAZER」のほうが良くないですか？ 「NUMEROUS」と「MANY」と「MULTIPLE」は、意味があまり違いません。もっと違う意味の言葉は、そのほうがいいかもしれません。「GALACTIC」などはどうでしょう。

[byronbytes]

It's mostly good to me, but I'm curious about the word "Omega" for overseas cultures. What do they think of "Omega"? "Omega" is somewhat common in America. I'm not sure why "Super Star" was changed into "Little Stargazer". Why not "Super Stargazer"? I think that the meanings of "Numerous", "Many", and "Multiple" aren't too different. Words that are more different might be better. Maybe words like "galactic"?

これは私の個人的な意見です。大部分がいいと思います。でも、外国人にとって「OMEGA」とはどうでしょうか。明らかな意味ですか？アメリカには「OMEGA」は少し通用です。 さらに、「SUPER STAR」は「LITTLE STARGAZER」に代えるのはなぜですか。「SUPER STARGAZER」のほうが良くないですか？ 「NUMEROUS」と「MANY」と「MULTIPLE」は、意味があまり違いません。もっと違う意味の言葉は、そのほうがいいかもしれません。「GALACTIC」などはどうでしょう。

Hmm, it was a little bit difficult to come up with words lol 😆, but I do like galactic, like it's out of this world!

[spenserblack]

#136 Gave me an idea. Just like themes, there could be a ?text= argument. This allows for different languages to be chosen, but also allows the user to choose the original text instead of the updated text (?text=original). This is less of a breaking change for users IMO.

#136 から考えが出来ました。テーマの同様、?text=で言葉を選べ方が出来ます。それで利用者は別の言語とか元の言葉とか選べられます。

[byronbytes]

#136 Gave me an idea. Just like themes, there could be a ?text= argument. This allows for different languages to be chosen, but also allows the user to choose the original text instead of the updated text (?text=original). This is less of a breaking change for users IMO.

#136 から考えが出来ました。テーマの同様、?text=で言葉を選べ方が出来ます。それで利用者は別の言語とか元の言葉とか選べられます。

Even better, with the addition of that feature you could add localization support for other languages (for example Japanese), and you could switch to custom languages like the old verison and new one.

[byronbytes]

I was thinking, instead of using words for the ranking, how about using things such as Bronze, Silver, Gold, Platnium, etc. I was looking back on my edits and some of them still feel "off" in a way, as in they were still gramatically incorrect in the given context.

(also thank you for replying, i almost forgot about this)

[spenserblack]

Standardizing to Bronze, Silver, etc. would certainly make translations easier!

const en = { silver: 'silver' }
const jp = { silver: '銀' }
const locales = { en, jp }
const text = locales[locale][level]

However, I think that unique text for each trophy is more fun, so there's a trade-off.

Part of the problem is that some adjectives are synonyms -- there isn't a strong difference between "many stars" and "multiple stars". Perhaps instead of adjectives, it should be nouns that change. It's much more difficult to think up appropriate wording, but I think can result in a much clearer distinction and more "natural-sounding" English. For example, the levels for number of followers could be

1. influencer
2. celebrity
3. deity

[byronbytes]

Standardizing to Bronze, Silver, etc. would certainly make translations easier!

const en = { silver: 'silver' }
const jp = { silver: '銀' }
const locales = { en, jp }
const text = locales[locale][level]

However, I think that unique text for each trophy is more fun, so there's a trade-off.

Part of the problem is that some adjectives are synonyms -- there isn't a strong difference between "many stars" and "multiple stars". Perhaps instead of adjectives, it should be nouns that change. It's much more difficult to think up appropriate wording, but I think can result in a much clearer distinction and more "natural-sounding" English. For example, the levels for number of followers could be

1. influencer
2. celebrity
3. deity

I believe this is a much better idea, since trying to change the adjective is a lot more difficult, due to trying to find the right word for both the noun / adjective to match. If worse goes to worst, there could just be a way for people to create custom text formats, which would go hand in hand with this suggestion

#136 Gave me an idea. Just like themes, there could be a ?text= argument.

People could create PR's with their versions (more preferrably themed as in it has a consistant naming scheme, so it's not random) and if it's good then they can push it.

[byronbytes]

Something glitched out and it closed the PR on accident while I was trying to push a change to my bramch. It should now be fixed.

[byronbytes]

Happy 2023 everyone! Decided to start on a complete previous code rewrite on all my features, added a lot of notes for better clarity, and overall improvements. For some reason the PR closed again, so I opened it back up. I'll be working on this overtime so things are still highly experimental.

Good catch! @byronbytes For the text editor you use, I'd recommend installing the EditorConfig plugin, so that the .editorconfig file will prevent formatting issues like this.

Sorry for the invisible spaces. I haven't been using a proper IDE which may cause things like that, I'll use something else in the next few hours (VSC, most likely)

[spenserblack]

For some reason the PR closed again

FYI PRs are auto-closed whenever the base branch or fork is deleted :slightly_smiling_face:

[byronbytes]

For some reason the PR closed again

FYI PRs are auto-closed whenever the base branch or fork is deleted 🙂

Good to know, I keep trying to push changes from another branch to the patch-2 one and I'm guessing that's why it keeps messing up.

[alexcastrodev]

@byronbytes I think this PR is have many changes and some comments of waiting for oppinions.

What you think close this one and open small PRs ? so we can review faster.

bests :)

[byronbytes]

@byronbytes I think this PR is have many changes and some comments of waiting for oppinions.

What you think close this one and open small PRs ? so we can review faster.

bests :)

Sounds like a good idea! I've been pretty busy lately but I'll start with the smaller PR's eventually.