beacon icon indicating copy to clipboard operation
beacon copied to clipboard

Published 20 hours ago • verified publisher icon rynbrd

Fix golint import path

Open golint-fixer opened this issue 6 years ago • 6 comments

I am a bot. Please reach out to @azillion if you have any issues, or just close the PR.

golint-fixer avatar Oct 24 '18 20:10 golint-fixer

Bot, this doesn't build!

rynbrd avatar Oct 24 '18 23:10 rynbrd

Go versions less than 1.9 will fail because they are not supported by golang.org/x/lint/golint Go Release Policy

azillion avatar Oct 25 '18 02:10 azillion

That's besides the point. If you're going to submit a PR it should at least build.

rynbrd avatar Oct 25 '18 04:10 rynbrd

I disagree. Feel free to close the PR if you want

azillion avatar Oct 25 '18 05:10 azillion

My point is that you can't expect people to merge PR's that don't build. That's got nothing to do with the supported state of the linter or whatever the most recent Go version is.

In short: if it don't build it don't fly.

rynbrd avatar Oct 25 '18 08:10 rynbrd

I have no expectations of people merging PR's they don't want. But even PR's with broken builds can still be helpful to people by making them aware that the version of Go they're using in a build is no longer supported by new releases. And for some that doesn't matter so they close the PR, and others update it. This was only meant to help, if it's not then please feel free to close the PR.

azillion avatar Oct 25 '18 14:10 azillion