ryley-o
ryley-o
@jakerockland - I've updated this PR's description based on recent merge of #386, and tagged you in a design-ish question in the TODO section 🙏 Also tagged you in a...
@jakerockland - tagging this as ready for review now that tests have been added and some minor iterations have been completed. Although you have already given a ✅ , would...
I do want to note that there is probably some gas golf that can be played on this minter, but I'm comfortable merging and doing that as follow-on work. totally...
@jakerockland - heads-up that I added a convenience getter function to help with subgraph code efficiency in commit 7a7bf22 🙏 Also - added a convenience getter function for number of...
@mchrupcala - thank you for your review! I've pushed an update to fix typo. please see my responses and either resolve if you are satisfied or continue the convo 🙏...
>@lyaunzbe one last nit, could we move the zk-sync folder to sit one directory higher? I don't think it needs to be under the PBAB+Collabs subfolder. ++ to this, with...
going to close this due, leaving it as a point of reference if any work related to zksync takes place. In general, it seems that most L2's are aiming for...
I believe the item holding this up may have been fixed: https://github.com/vyperlang/vyper/issues/2903#issuecomment-1370273109
Going to close this PR to clean up the pending PRs in this repo. PR will remain available in closed state as a point of reference in the future if...
here is a current report - should probably do some tweaking to only report non-PBAB contracts, and the branch coverage looks a little odd... https://coveralls.io/builds/54646910