Ryan Levick

Results 190 comments of Ryan Levick

This would be useful for the windows ecosystem (perhaps inside the [`windows` crate](https://crates.io/crates/windows)) to declare wide string literals. Even though there are plenty of [workarounds](https://crates.io/crates/wide-literals) for wide string literals, having...

Correct this is only being used inside of proc-macros, so this won’t help. Then I need to figure out how to profile inside of a proc-macro as we need to...

@mystor Unfortunately it seems that self profiling rustc does not yield much information as proc macros seem to show up as "macro_expand_crate" without any detailed information.

Thanks! That helps! I notice a few interesting tidbits like the fact that `quote::__private::push_ident` is much more expensive appearing than I would have thought. Also, a good place to focus...

After doing more profiling I thinking going the route of string concatenation is best. The only down side of this is losing the nice experience of using the `quote!` macro....

@dtolnay So I worked on adding a new `TokenString` type to quote which simply wraps a string buffer instead of a TokenStream. I also crated a `squote!` which mimics `quote!`...

@dtolnay ping! 😀 just need to know if a string backed quote macro would be interesting to add to this crate or if I should make a new crate for...

@dtolnay Is the suggestion to do the following: * change `proc_macro2::TokenStream` to contain an ordered collection of `proc_macro2::imp::TokenStream` and `String`. The `proc_macro2::imp::TokenStream`s would be for any case where eager evaluation...

It seems like that the existing issues that fit in this category are quite simple: https://github.com/rustwasm/gloo/issues/6#issue-414841275 Perhaps we should just create them, and more information can be added later.

> No, I don't think so. If it's worth putting in a crate then it's worth putting in Gloo (IMO). But I just don't think it's worth putting in a...