rye icon indicating copy to clipboard operation
rye copied to clipboard

Library request in cdnjs.

Open Piicksarn opened this issue 7 years ago • 7 comments

Hi ~ There's a library request in cdnjs, and we desire to contain rye . However, I must to make a check for the files that we need to added.

The file i would like to add is:

lib/rye.js

Is that complete for the user? Or other files required?

Thanks for your great work ✨

Piicksarn

Piicksarn avatar Oct 27 '16 15:10 Piicksarn

Hi @Piicksarn! The right files to add would be dist/rye.js and dist/rye-base.js, which are the result of running cake build + cake build --light, and not currently commited to the git repo.

Now I feel like updating this to use a package bundler :)

ricardobeat avatar Oct 30 '16 17:10 ricardobeat

@ricardobeat :sparkles: , thanks! I'll update the pr which I send to cdnjs later. Before that, would you mind to provide latest dist/rye.js, dist/rye-base.js on github and use git tags? Since I found the latest version of rye is 0.1.0 :point_right: http://ryejs.com/dist/rye-0.1.0.js, and cdnjs use git tags for library auto-update. If rye could use git tags, then the files contained in cdnjs will be updated automatically when the new versions released. :smiley:

Piicksarn avatar Nov 07 '16 08:11 Piicksarn

@Piicksarn I'll see about updating it.

ricardobeat avatar Nov 07 '16 15:11 ricardobeat

@Piicksarn take a look at #37, would making the package npm-install-friendly help?

WesSouza avatar Nov 13 '16 04:11 WesSouza

#37 has been merged, dist/rye-base.js and dist/rye.js are commited, and the library is now published on npm: http://npmjs.com/package/ryejs

@Piicksarn anything else needed from our side?

ricardobeat avatar Nov 16 '16 22:11 ricardobeat

@ricardobeat , the license was ISC before, and now is MIT, so is that fine we discuss ryejs as double licenses with both "MIT" and "ISC", or only MIT license uses?

Piicksarn avatar Nov 19 '16 08:11 Piicksarn

@Piicksarn yes, our license is ISC.

WesSouza avatar Nov 29 '16 02:11 WesSouza