Eigengrau-s-Essential-Establishment-Generator icon indicating copy to clipboard operation
Eigengrau-s-Essential-Establishment-Generator copied to clipboard

Refreshing page leads to NPC Life Savings and Income Error

Open MagicCraft37 opened this issue 5 years ago • 3 comments

Describe the bug When the page refreshes or a save is created and loaded on an NPC, any values on their page that uses cash breaks. An error is spit out and the value is not displayed. The error only appears for that NPC and will not be an issue for others unless the before described steps are done on a different NPC.

To Reproduce (bugs MUST be replicable) Refreshing the Page: Open any NPC's description page (Clicking on NPC name) Refresh the current page.

Save Error: Navigate to any NPC's description page Select the save button, save to any slot Select the save button, and load that save

Town Seed (click here for info):

#madalarmingwoodpecker

Additional context The direct errors are listed here: Error: <>: bad evaluation: npc.partnerGenderProbability is not a function Error: <>: bad evaluation: State.variables.currentNPC.finances.lifestyleStandard is not a function Error: <>: bad conditional expression in <> clause: Cannot read property '1' of undefined Error: <>: bad evaluation: State.temporary.value is not a function Error: <>: bad evaluation: Cannot read property '0' of undefined

MagicCraft37 avatar Sep 16 '20 17:09 MagicCraft37

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.98. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar Sep 16 '20 17:09 issue-label-bot[bot]

I believe that this is a duplicate of #280, however this has replicable steps, so I'm closing #280. Was not aware that it also breaks on save/load, so this is very useful. Thanks for the bug report, keep 'em coming!

ryceg avatar Sep 17 '20 00:09 ryceg

This is very likely a result of serializing/deserializing objects with functions/getters/setters.

Glinkis avatar Sep 17 '20 06:09 Glinkis