ryan neptune

Results 80 comments of ryan neptune

Great repro @ramtinsoltani! I reproduced it now too locally in Windows 7 in Chrome and FF. I isolated it to `viewportH()` returning a value that's too high. [`viewportH()` uses](https://github.com/ryanve/verge/blob/1.10.2/verge.js#L26-L29) a...

Whoa I just figured out why the local differs from the codepen. Local has no doctype, If you add one then it works as expected! [Discovered via S/O](https://stackoverflow.com/a/25979612/770127) ```html ```...

[`document.doctype === null` when doctype is missing.](https://developer.mozilla.org/en-US/docs/Web/API/Document/doctype) We could use that to `console.warn` about it.

Hmm reasonable logic. [The current logic is inclusive of both endpoints.](https://github.com/ryanve/verge/blob/1.9.1/verge.js#L157)

A separate method like `$.between.call(test, min, max)` for use like `_.find(list, $.between, $.viewportW)` is possible alternative.

@AmmsA you can do that with the second argument https://github.com/ryanve/verge/tree/1.10.2#inviewport

@illarionvk cool—thanks for the detailed input!

To be safe I think `inViewport` should stay the same. But we could add a separate `isVisible` method. Do you think that fits within the scope of the library or...

Sure sounds cool if you want to make a pull request

`.inViewport`, `.viewportW`, `.viewportH` should all work in IE6+ does that help?