Ryan Toronto

Results 100 comments of Ryan Toronto

I ran into this today. Wondering if there's a recommendation for addons that use `ember-fetch` as a dependency? Edit: For my use case I was able to get away with...

Woohoo! 🎉 Any thoughts on this PR? It would help us with https://github.com/embermap/ember-cli-fastboot-testing/pull/61

Hi @valscion Thanks for the write up, it was helpful in understanding this issue! Do you still think the best action is to write a test for the following? >...

Happy to merge any PRs that address this.

Let's do whatever is simplest. We can release a new breaking version of the gem and in the release notes gives folks a migration that they can copy/paste into their...

Ok I think this one is next! I'm excited to get your fix published. Want to rebase it for specs?

Heya! Yes, I want to get this in. This approach is great and it's what we will be using. If you want to use a fork of this PR I'd...

Does manually updating the cached votes fix this? `votable.update_cached_votes` ?

This looks great! If you want to rebase off master to get CI running that would be helpful.