dom-expressions icon indicating copy to clipboard operation
dom-expressions copied to clipboard

Published 20 hours ago • verified publisher icon ryansolid

Fix reconcileArrays assuming non-empty input array

Open EricNRodriguez opened this issue 2 years ago • 3 comments

EricNRodriguez avatar Jul 30 '22 06:07 EricNRodriguez

Is there a place where you hit this as a bug?

ryansolid avatar Jul 31 '22 02:07 ryansolid

I was using it directly in a side project and came across it, thought I would correct it whilst I was here. I didn't find any cases where it caused a crash elsewhere, but I also didn't look extensively

EricNRodriguez avatar Jul 31 '22 09:07 EricNRodriguez

Ok the reason I asked is mostly it is a hot path and if it isn't neccessary Id skip. Plus we don't transpile and there are envs that don't support optional chaining so we'd need to make a slightly larger fix. Unless there is a bug/code path where this causes an issue Id be tempted to leave as is

ryansolid avatar Jul 31 '22 15:07 ryansolid

Makes sense - I have no strong opinions so I'll close this off given the above info. Thanks Ryan

EricNRodriguez avatar Aug 01 '22 08:08 EricNRodriguez