component-register icon indicating copy to clipboard operation
component-register copied to clipboard

Published 20 hours ago • verified publisher icon ryansolid

Update typescript version

Open CreativeTechGuy opened this issue 1 year ago • 1 comments

Fixes #24

TypeScript's lib.dom.ts has been updated. The previous compiled version of this library is missing types if users are on a new version of typescript. This brings the library up to current.

CreativeTechGuy avatar Nov 10 '23 00:11 CreativeTechGuy

@ryansolid Would you be willing to merge this fix and release a new patch version to fix this issue? I think my PR should have everything ready to go to be released for you. 😄

CreativeTechGuy avatar Nov 10 '23 00:11 CreativeTechGuy

Hi @ryansolid , are you able to take a look at this PR to help unblock users?

CreativeTechGuy avatar Feb 08 '24 22:02 CreativeTechGuy

I'm getting an error I think that's related to this

../../node_modules/component-register/types/element.d.ts(183,25): error TS2304: Cannot find name 'DocumentAndElementEventHandlers'.

captDaylight avatar Feb 13 '24 15:02 captDaylight

maybe @jurijzahn8019 can help with this?

captDaylight avatar Feb 13 '24 15:02 captDaylight

Hi, not really, since many functions do not have return types, those are inferred during compile time, and by using the version of lib.dom used to compile against. By updating typescript version those types may break in CAS they were removed. So the only way to fix this with using type inference is to recompile with newer typescript version.

jurijzahn8019 avatar Feb 13 '24 19:02 jurijzahn8019

Thanks

ryansolid avatar Jun 27 '24 19:06 ryansolid