Ryan Carniato
Ryan Carniato
I haven't touched this one since it is marked as draft. Are there more changes, or things that need to be verified?
Ok I like it. We probably have to wait for minor given how this could break types. I've broken types on patch releases before but I feel like we should...
Yeah this by design... reviewing this again I see that the log does happen, just in the browser, on navigation. The reason for the 3 logs is the way SSR...
@heilwood thanks for the update. I wasn't able to get this on the docs site so closing for now. But if it surfaces again would appreciate the issue.
Yeah.. it's because of the lazy access of meta tags to insert them in the head. I see its in the head there but we don't really need to render...
Yeah thanks. It's because it doesn't use our typical server rendering. In this case I think something simple like this should work and we don't need our full resolver.
We can't diff what is outside of our control. SSR does a trick where it replaces by writing an attribute to server generated meta tags. We should document this. But...
You have multiple MetaProviders. Each acts independently. Wrap the whole application in a single MetaProvider and it should work fine. See: https://codesandbox.io/s/solid-meta-reproduction-3r1qgb
Yeah I thought this might be the case. We used to do something simple and just remove all the existing tags but now we try to upgrade but if the...
We never removed or commandeered the title tag if it didn't have a data-sm attribute. 0.28.0 removed the ability to have an existing title tag at all, but that should...