sqlclosecheck

sqlclosecheck copied to clipboard

Statements prepared in transaction do not need to be closed

1

Because, quoting documentation, "The statements prepared for a transaction by calling the transaction's Prepare or Stmt methods are closed by the call to Commit or Rollback.". https://pkg.go.dev/database/sql#Tx Linter should avoid...

bunyk

Check Row.Scan calls

1

The sql.Row structs returned by the QueryRow methods contain a reference to a sql.Rows instance that is only closed when Scan is called. (see https://cs.opensource.google/go/go/+/refs/tags/go1.17.3:src/database/sql/sql.go;l=3326) Thus i think that this...

Lumaraf

sqlclosecheck crashes when sql.Stmt is stored in global var

1

sqlclosecheck doesn't work correctly in this case. #20 - a concrete test case. Maybe this approach of dealing with Stmt is not good, but we have some small go scripts...

TelpeNight

support check conn.QueryRow() without Scan()

1

I meet the case that someone write ```go if err := conn.QueryRow(query, args...).Error(); err != nil { } ``` the conn leaks. In fact, he wants to Exec(query, args...). I...

SennoYuki

ryanrolds