vim-devicons icon indicating copy to clipboard operation
vim-devicons copied to clipboard

[fix] NERDTree automatic refresh #224

Open realSaltyFish opened this issue 3 years ago • 8 comments

Requirements (please check off with 'x')

Note: The link to the Contributing Guidelines is broken.

What does this Pull Request (PR) do?

It fixes the bug reported in #224.

How should this be manually tested?

After applying this update, open NERDTree and create a new file. NERDTree will now automatically refresh and show the icon for the new file.

Any background context you can provide?

NERDTree buffers have buftype="nofile", so the CursorHoldUpdate() function will return prematurely when a NERDTree buffer is focused. This PR adds a buftype detection for NERDTree, preventing the return.

What are the relevant tickets (if any)?

#224

realSaltyFish avatar Dec 14 '21 15:12 realSaltyFish

Great and appreciate the contribution 🥇

I will have to pull it down and test it out...

Note: The link to the Contributing Guidelines is broken.

Thanks for catching that! Fixed!

ryanoasis avatar Dec 15 '21 02:12 ryanoasis

Hi, I added a commit to fix the style issues. Please review it, thanks!

realSaltyFish avatar Dec 20 '21 02:12 realSaltyFish

Sorry, I want to test this out locally. Need to get caught up

ryanoasis avatar Jan 10 '22 02:01 ryanoasis

I'm gonna help testing it out because I am having this issue as well

cizordj avatar Feb 25 '22 16:02 cizordj

I've been using this for a while and it does solve the problem, however it takes 5 or more seconds to refresh the icons and when I create new files in the root directory it doesn't refresh the icon sometimes.

cizordj avatar Mar 05 '22 17:03 cizordj

I'm waiting for that issue to be resolved. How is it going?

parkgang avatar Jul 29 '23 06:07 parkgang

@parkgang I'm no longer using nerd tree but you can try using this one instead: https://github.com/nvim-tree/nvim-tree.lua

cizordj avatar Aug 04 '23 13:08 cizordj