nerd-fonts icon indicating copy to clipboard operation
nerd-fonts copied to clipboard

Update Font Logos to 1.0.1

Open Finii opened this issue 1 year ago • 3 comments

Description

Before Font Logos 1.0.0 there was no stable-codepoint guarantee, and the later revisions (0.18) reassigned the codepoints. That makes updating for us very hard, because we would have to resort the icons or follow the codepoint changes.

With 1.0.0 this changed. That new major release introduced not only a codepoint guarantee, but it also shifted the codepoints from the F100 region to the F300 region, where we put them anyhow (in most cases). That is one subset less with 'dynamic base codepoint'.

The reassignment of codepoints in Font Logos kept the codepoints stable for the icons we already have in release 2.1.0. But at the moment the 2.2.0 Release Candidate (which updated Font Logos with commit 557b8da) have added glyphs, which are on different points as compared with the Font Logos 1.0.0 release.

What I want to say, we need to get this straight, before our 2.2.0 RC turns into a Release 2.2.0.

Requirements / Checklist

What does this Pull Request (PR) do?

Update Font Logos to the latest release 1.0.0 (with codepoint stability guarantee)

How should this be manually tested?

Any background context you can provide?

https://github.com/lukas-w/font-logos/issues/72 https://github.com/lukas-w/font-logos/issues/33

#551 Puts new glyphs at codepoints that differ from the now-fixed and 'cast into stone' codepoints of Font Logos 1.0.0.

Discussion on codepoints also here https://github.com/ryanoasis/nerd-fonts/issues/656#issuecomment-1020933693 and following

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Font Logos 1.0.0 glyphs at position F300 and following, no gaps

image

A lot of thanks to @lukas-w who made the new Font Logos release possible and added codepoint stability as one of the objectives.

Finii avatar Jul 07 '22 06:07 Finii

See also #778 for our own codepoint stability. One half of that is obsoleted by the MR.

Finii avatar Jul 07 '22 06:07 Finii

font-logos has a 1.0.1 release with some fixes. Maybe it would make sense to use 1.0.1 straight away.

alesya-h avatar Jul 16 '22 09:07 alesya-h

Thanks for the ping, I'll update this PR.

Finii avatar Jul 16 '22 09:07 Finii