Add Netwide Assembler (NASM) icon

[ignamartinoli]

Requirements

• [x] I have searched the issues for my request and found nothing related and/or helpful
• [x] I have searched the FAQ for help
• [x] I have searched the Wiki for help

Is your feature request related to a problem? Please describe.

It would just be a nice add-on

Describe the solution you'd like

It would be cool to have an icon for Assembly languages for nvim-web-devicons and exa to use

Describe alternatives you've considered

I don't know any other solution

Additional context

There is no icon nor mascot for Assembly .asm files in general, but Netwide Assembler is quite popular and with its icon could fit that spot

[Finii]

Related:

https://github.com/ogham/exa/issues/1080

exa does not handle .asm at the moment at all: https://github.com/ogham/exa/blob/master/src/output/icons.rs

[Finii]

lsd uses E614, which looks like a #

https://github.com/Peltoche/lsd/blob/master/src/icon.rs

That icon comes from Seti UI & Custom.

Well, I would not call # to be a good asm icon. But this two balls, one big and a smaller top right, THAT would remind me too much of Lua (see glypg list above, the icon just below the #.

I see no consensus of assembler programmers for one specific icon, and the lack of a real icon for nasm does increase the impression they themselves do not count the two-balls thing relevant as 'this is asm' indicator.

The idea is good, but when I'm working with asm files and this icon turns up, I would think it a bug?

[ignamartinoli]

I agree on that. I didn't thought about the similarity with Lua's icon, which is actually an embedded language so it wouldn't be too crazy to appear in a same codebase.

I can bring some better alternatives:

This one would be consistent with C and C++ ones and since the text is 3 letters only one would be able to distinguish it well enough

These two goes for a completely different route, suggesting the language operating on the CPU

What do you think about this ones?

[ignamartinoli]

As an update, I was able to get this icon, which resembles the C/C++ but has a different shape orientation. Does it seem like a good idea? Any feedback before creating a PR?

[Finii]

I must admit I think it looks quite good :grimacing:

[ignamartinoli]

Thanks @Finii! I will figure out how to create a PR and link the issue

[Finii]

Some hints are in https://github.com/ryanoasis/nerd-fonts/blob/master/contributing.md#contributing-guide

The link in our documentation is broken I just noticed, it is https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github

You need to turn your attention to the files in src/svgs/ in this repo. In principle... read that README, put your .svg there, and add the appropriate data to icons.tsv. After pushing the repo to github it will automatically rebuild src/glyphs/original.source.ttf with your icon included. Download that and check with fontforge or other font examination program.

(The font rebuild via github action can also be 'imitated' on your local machine, by running cd bin/scripts && ./generate-source-source.py, but that needs some stuff to be existing on your machine.) Do not put the generated font file into the PR.

:-) :+1:

[ignamartinoli]

@Finii I just opened a PR.

I'm not that experienced neither with Git nor this project so if there is any mistake please tell me so I can improve for my next contribution.

I wasn't able to use FontForge to verify, it would show me almost no icons.

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.