nerd-fonts icon indicating copy to clipboard operation
nerd-fonts copied to clipboard

font-patcher: Allow glyphs with altuni for exactEncoding

Open Finii opened this issue 3 years ago • 2 comments

Description

[why] Some symbol fonts might come with glyphs that have multiple codepoints.

When we want to patch them with 'Exact': true (i.e. at their 'original' codepoints) we want to patch them into the codepoint that has been used in the selection process. That means between SymStart and SymEnd.

But this is not the case. We patch them in into their 'main' codepoint, which can be outside the expected range of points.

This came up when patching with FontAwesome V6. It has for example these glyphs:

Glyph 'music' has a main codepoint 0x1F3B5, but it is present in the font also on codepoint 0xF001.

Glyph 'heard' has a main codepoint 0x1F9E1, but it is present in the font also on codepoints 0x2665, 0x2764, 0xF004, 0xF08A, 0x1F499, ...

When doing a 'Exact': true patch (i.e. exactEncoding = true) the glyphs is patched into the target font at its (the glyph's) main codepoint, regardless of our patch-codepoint-range.

[how] We examine all codepoints that a glyph occupies in the symbol font. From all these codepoints we take the nearest to the last glyph be patched in. Nearest means from the possible codepoints the lowest that come after the previous used codepoint.

For example the 'heard':

Last patched in codepoint was 0xF003. Main codepoint: 0x1F9E1 Alternate codepoints: 0x2665, 0x2764, 0xF004, 0xF08A, 0x1F499, ... -=> 0xF004

Later in the patching process we might encounter the same glyph again, but this time the previous codepoint was 0xF089, so we need to take 0xF08A.

Requirements / Checklist

What does this Pull Request (PR) do?

Put symbol glyphs that have additional unicodes (altuni) into the expected (i.e. next possible in the range we work on) codepoint slot.

From Fontforge Python Docu:

glyph.altuni

Returns additional unicode code points for this glyph. For a primary code point, see glyph.unicode .

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

https://github.com/ryanoasis/nerd-fonts/discussions/727#discussioncomment-2227926

Screenshots (if appropriate or helpful)

Finii avatar Feb 22 '22 11:02 Finii

The code had a bug when the primary codepoint is low (i.e. lower than the current slot we work on). That is not the case for any FontAwesome V6 glyph, but it would be possible for some future symbol font. Force push

Finii avatar Feb 22 '22 12:02 Finii

*cough*

                     possible_codes += [ v for v, s, r in sym_glyph.altuni if v > currentSourceFontGlyph ]
-                currentSourceFontGlyph = sorted(possible_codes)[0]
+                currentSourceFontGlyph = min(possible_codes)
             else:

force push

Finii avatar Feb 22 '22 13:02 Finii