nerd-fonts icon indicating copy to clipboard operation
nerd-fonts copied to clipboard

Patched Iosevka font will remove ligature inside it

Open GulajavaMinistudio opened this issue 3 years ago • 7 comments

There is compatibility issue in Nerd Font Patcher for Iosevka 11 or up version. I try patching Iosevka 11.x with font patcher, but causing ligature removed from it. I want to keep ligature inside Iosevka 11, but the font patcher remove it.

And in Terminal progress, there's some error warning , i think this is causing ligature can't work in Iosevka 11 ?

"Internal Error: Attempt to output 66740 into a 16-bit field. It will be truncated and the file may not be useful."

Screen Shot 2021-12-29 at 07 34 53

And here is my command to running font patcher fontforge -script ./font-patcher ./iosevka-bolditalic.ttf --complete

Any ide to bring back ligature in patched Iosevka 11's font ?

GulajavaMinistudio avatar Dec 29 '21 00:12 GulajavaMinistudio

Which ligature is it you miss?

Finii avatar Dec 30 '21 07:12 Finii

Which ligature is it you miss?

After patching with font patcher, "calt" and "dlig" is removed from Iosevka. I want to keep it like Iosevka v10 and older. But in Iosevka 11, ligation can't be shown because it's removed.

GulajavaMinistudio avatar Dec 30 '21 08:12 GulajavaMinistudio

Running into this same issue (I'm getting a different number though) https://github.com/fontforge/fontforge/issues/3009 I'm assuming the table responsible for generating ligatures is getting cut off. Iosevka has a LOT of features so maybe that's why.

xsrvmy avatar Jan 03 '22 03:01 xsrvmy

I'm still use font patcher in master branch, and try to use other Iosevka variant called "Iosevka Fixed" that contain no built in ligature and no built in glyph. And this run successfully without "truncated error" like previous screenshot with Iosevka and Iosevka Term.

Here is newest screenshot with "Iosevka Fixed" variant Screen Shot 2022-01-07 at 22 46 43

And here package list link for description about Iosevka Fixed. https://github.com/be5invis/Iosevka/blob/v11.2.4/doc/PACKAGE-LIST.md

I think font patcher will get error if there's some built in ligation and glyph, especially in Iosevka or other font like Fira Code.

GulajavaMinistudio avatar Jan 07 '22 15:01 GulajavaMinistudio

In my case, Iosevka's term spacing is missing ligatures but fontconfig-mono works. Building fontforge from source with fontforge/fontforge#4883 fixes the issue.

ObserverOfTime avatar Feb 13 '22 10:02 ObserverOfTime

Which ligature is it you miss?

Hello Mr @Finii , any progress about Iosevka font ? is bug fix is coming with fontforge ? or any workaround ?

GulajavaMinistudio avatar Mar 03 '22 05:03 GulajavaMinistudio

I was able to fix the bug in fontforge, and that has been merged (see OberverOfTime's comment above). So if you self-build fontforge from HEAD it is fixed. Self-building is not complicated (at least on *ix). When they release a version with the fix, I have no clue.

Finii avatar Mar 03 '22 05:03 Finii

In the meantime fontforge released a new verion that contains my patch and that error is fix in that fontforge.

So please, use a 2022 March fontforge together with the font-patcher and all should be well. This was not a bug in Nerd Fonts.

You can use the fontforge AppImage if you have no updated system package, for example:

curl -LO https://github.com/fontforge/fontforge/releases/download/20220308/FontForge-2022-03-08-582bd41-x86_64.AppImage
chmod u+x FontForge-2022-03-08-582bd41-x86_64.AppImage
./FontForge-2022-03-08-582bd41-x86_64.AppImage -script .../path/to/font-patcher ...

Finii avatar Oct 29 '22 08:10 Finii

I'm still having this issue with the latest fontforge appimage (20220308).

EDIT: Just tried building fontforge from the main branch of the repo and using that, same issue.

Bahnschrift avatar Nov 20 '22 06:11 Bahnschrift

I'm still having this issue with the latest fontforge appimage (20220308).

Well, your problem (#997 after closing) is different than this one here. Previous fontforge releases could not write the ligature table at all (i.e. the offsets within the font file were wrong). So the ligature table was destroyed - and fontforge detected it, issued a warning.

Finii avatar Nov 20 '22 11:11 Finii

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

github-actions[bot] avatar May 22 '23 00:05 github-actions[bot]