Problem with VictorMono in VSCode with ligatures enabled.

[tefloon]

🎯 Subject of the issue

The issue is similar but not identical to #415 and #494 For some reason, the ligatures in italics don't work properly in VSCode. They seem to be shifted to the right by one space, overlapping the next character:

What's even stranger, when the ligatures are turned on in VSCode settings ("editor.fontLigatures": true), a bunch of ligatures appear that shouldn't exist. As far as I could tell they mostly involve "a", "e" and "l" (lowercase L) creating complexes with all lower-case letters. This results in a complete gibberish in certain places:

Turning off the ligatures in the settings ("editor.fontLigatures": false) causes these to go away:

Below are some more examples I created to try and work out what's happening. I also made a screenshot of the lines selected so that it's possible to see spaces and other unprintable characters. Note: there is always just one space between the slashes and the word.

Sublime Text 3 with the same settings on the same system works perfectly without any weird behaviour:

🔧 Your Setup

• Font: VictorMono Nerd Font Mono (downloaded as is from the NF website)
• System: Windows 10 Pro, Version 21H1, build 19043.1110
• Editor: Visual Studio Code, Version: 1.58.2
  • Commit: c3f126316369cd610563c75b1b1725e0679adfb3
  • Date: 2021-07-14T22:10:15.214Z
  • Electron: 12.0.13
  • Chrome: 89.0.4389.128
  • Node.js: 14.16.0
  • V8: 8.9.255.25-electron.0
  • OS: Windows_NT x64 10.0.19043

[laundmo]

im experiencing the same issue. the issue does not exist with the base Victor Mono

[eltariel]

This isn't just in vscode...

I had initially installed all of the "windows compatible" variants and I was seeing the same issue in a couple of other apps on Windows10 (neovide and nvui in particular). I didn't actually attempt to run either of these with ligature support disabled.

I removed all of the font files and then reinstalled just the non-mono subset (i.e. Victor Mono X Windows Compatible.ttf and not Victor Mono X Mono Windows Compatible.ttf) and the issue has gone away.

[Finii]

Installed

patched-fonts/VictorMono/Regular/complete/Victor Mono Regular Nerd Font Complete Mono Windows Compatible.ttf
patched-fonts/VictorMono/Italic/complete/Victor Mono Italic Nerd Font Complete Mono Windows Compatible.ttf

In writer the ligatures break when italic is turned on:

I have seen something similar already :thinking:

[Finii]

I suspect either a2f0958ae or d307a7335

lets see if that fixes this.

[Finii]

Unfortunately not. It's already visible on Linux just in the font opener :unamused:

Otoh, that will make it more easy to find the reason :+1:

The font shown above has been just now patched with font-patcher HEAD, so the suspected commits did not change it.

Edit: Add last (explanatory) sentence

[AlexPoulsen]

i get the same issue on macos, well just in the quicklook preview, haven't gone past that point yet. just mono versions and windows compatible doesn't affect it.

just these files, and their ... Windows Compatible versions, are affected for me:

Victor Mono ExtraLight Italic Nerd Font Complete Mono.ttf
Victor Mono Italic Nerd Font Complete Mono.ttf
Victor Mono Light Italic Nerd Font Complete Mono.ttf
Victor Mono Medium Italic Nerd Font Complete Mono.ttf
Victor Mono Thin Italic Nerd Font Complete Mono.ttf

[Finii]

Can not reproduce with v3.0.0 anymore.

[dbGIS]

It appears to be fine for VictorMonoNerdFont-*.ttf but not for VictorMonoNerdFontMono-*.ttf

VictorMonoNerdFont-Regular

VictorMonoNerdFontMono-Regular

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.