nerd-fonts icon indicating copy to clipboard operation
nerd-fonts copied to clipboard

Caskaydia Cove introduces ligature issue not in Cascadia Code

Open Kissaki opened this issue 2 years ago • 16 comments

Testing in Windows Terminal - font size 12, Windows 11, NF v3.0.2

I would expect the ligature for => to be the same and without visual artifacts.

Cascadia Code:

image

CaskaydiaCove Nerd Font Mono:

image

🗹 Requirements

  • [x] I have searched the issues for my issue and found nothing related and/or helpful
  • [x] I have searched the FAQ for help
  • [x] I have searched the Wiki for help

Kissaki avatar Jun 06 '23 16:06 Kissaki

Oh, sorry to hear that. Lets find the reason.

Works in Writer

image

Finii avatar Jun 07 '23 18:06 Finii

I see the same, in Windows Terminal as well as in VS Code, Nerd Fonts 3.0.2

image

phjordan avatar Jun 08 '23 07:06 phjordan

Can not reproduce on Win10, VS Code 1.71.0, NF 3.0.2:

image

My settings:

image

Finii avatar Jun 08 '23 11:06 Finii

The problem with Windows Terminal is that they bundle Cascadia Cove (VF) with it and one can not uninstall it, which I hate.

Installing that thing now, hold tight.

Finii avatar Jun 08 '23 11:06 Finii

@phjordan Btw, please share a picture of your config.json and maybe a view of the font settings dialog with 'cas' as search term:

image

You see I have no Cascadia Code installed. I unpacked the Caskaydia zip file, select all, right click, install (for user) (is how I installed the fonts).

Finii avatar Jun 08 '23 11:06 Finii

Can see it with Windows Terminal:

image

(:thought_balloon: Now I can not restart VS Code, great)

Finii avatar Jun 08 '23 11:06 Finii

  • Could not start VS Code
  • Revert changes in config.js - still not opening
  • Remove VS Code via 'apps'
  • Reinstall VS Code via MS Store - problem: can not install
  • Reboot
  • Reinstall VS Code via MS Store - problem: can not install
  • Download VS Code msi
  • Install - can not overwrite old files?
  • Reboot / manual deletion of old files
  • Install ok
  • Start ... still not opening

Windows is so easy, everything works out of the box!

Finii avatar Jun 08 '23 11:06 Finii

Here are my font settings, Both 'Cascadia Code' and 'CaskaydiaCove...' are installed for all users.

image

I noticed that the editor.fontSize-setting does have an effect. I don't know anything about font rendering and scaling, but maybe this observation is of help. With 'Cascadia Code' set as font, the arrows seem fine for all font sizes.

My original VS code settings.json: image

It looks fine with editor.fontSize commented out: image

It looks fine with font size 14: image

Font size 12: image

Font size 22: image

Edit: This is on Windows 10

phjordan avatar Jun 08 '23 12:06 phjordan

Thanks for the input! There are indeed size-limits where the font switches rendering, I will check that. And maybe I can get VS Code repaired on that one machine, all other machines I have are Win11...

Edit: Ah, report was for Win 11 :woman_facepalming:

Finii avatar Jun 08 '23 13:06 Finii

Ah, I have another hunch... Which concrete Cascadia Code did you compare with? (Best would be a details screenshot of the font settings thing, when opened Cascadia Code)?

I fear that it might be the hints 🙄

Finii avatar Jun 08 '23 15:06 Finii

Which concrete Cascadia Code did you compare with?

This is the reason why I hate the bundling of Windows Terminal with Cascadia Cove, because they bundle the VF and one has to go through a lengthy operation to remove that if you want the otf or pure ttf ones instead.

The font-patcher can not work with VF, so we use some static ttf variant (see the readme)

Finii avatar Jun 08 '23 15:06 Finii

Which concrete Cascadia Code did you compare with? (Best would be a details screenshot of the font settings thing, when opened Cascadia Code)?

Yes, it seems to be the bundled version of Cascadia Code that I have installed. image

phjordan avatar Jun 08 '23 15:06 phjordan

Thanks for the input! There are indeed size-limits where the font switches rendering, I will check that. And maybe I can get VS Code repaired on that one machine, all other machines I have are Win11...

Edit: Ah, report was for Win 11 🤦‍♀️

Also reproducible on windows 10 👍🏼

FrancescoLuzzi avatar Jun 22 '23 08:06 FrancescoLuzzi

I also encountered this issue. Windows 11, Windows Terminal 1.17

image Can see that -- near git are of different sizes

image And it gets better with font size increase.

azdanov avatar Jun 28 '23 04:06 azdanov

I've Installed the latest version of Caskaydia Cove NF on my windows 10, and now I'm seeing this box icons, I need help regarding this issue

image

image

harshv5094 avatar Jun 29 '23 14:06 harshv5094

@harshv1741 This is no ligature Issue.

Please check out

  • https://github.com/ryanoasis/nerd-fonts/issues/1190#issuecomment-1530999114

Finii avatar Jun 29 '23 16:06 Finii

I would need someone who can test the potential fix, good would be a thorough test like @phjordan with all the arrows.

Finii avatar Apr 18 '24 15:04 Finii

It would be great if someone who sees the arrows problem can check this font:

CaskaydiaCove_arrows.zip Version 3.2.1-10

(Probably you need to uninstall the old Caskaydia first, then reboot, then install the font given in this comment.)

Without reports it is hard to see if this will fix it or not... Help needed.

Finii avatar Apr 20 '24 20:04 Finii

Thanks for the update, i'll give it a try as soon as I can!

FrancescoLuzzi avatar Apr 20 '24 21:04 FrancescoLuzzi

It seems to be 99.9% resolved!

In some font sizes the "=>" ligature has a really small defect (there is a really small gap between the "equal" sign and the "greater than" sign image

This is the "correct" arrow on a different size: image

Same thing with: image

FrancescoLuzzi avatar Apr 21 '24 10:04 FrancescoLuzzi

Hmm, this is maybe also a hinting problem, this is most visible at 12 pt / 96 dpi.

image

The advance width is 9.4 pixel, and so the last pixel is only filled less than half, so it is rendered half-grey. Of course this will vary with the number of characters in front of it.

The situation is comparable with FiraCode unpatched:

image

Just here other sizes show that same problem.

Are you sure Cascadia Code unpatched does not have the same problem at some sizes? Maybe you can try. I need to fire up Glyphs3 to examine it. Or was there not a tool on Linux to show the subpixel rendering of variable fonts on Linux :thinking:

I can check, but I believe this is a principle problem that can not be solved without 'massive' manual intervention.

Affected are a high number of glyphs (the font-patcher reports it auto-adjusts 88 glyphs), so that would be quite some work to do, manually edit the hints to extend more to the outside. Well, and famous FiraCode has the same, so why should we be better ;-)

Finii avatar Apr 21 '24 13:04 Finii

Are you sure Cascadia Code unpatched does not have the same problem at some sizes? Maybe you can try.

Just uninstalled Caskaydia Cove, rebooted and tried using Cascadia Code, the issue is still there image

Well... your patch worked just fine, it seems that Cascadia Code is the problem now. Thanks!

FrancescoLuzzi avatar Apr 21 '24 14:04 FrancescoLuzzi

Thank you for testing all that stuff! I will do some final tests with the PR (because it completely changes how the configuration works), and then merge the fix.

Finii avatar Apr 21 '24 14:04 Finii

@allcontributors please add @FrancescoLuzzi for bug

Finii avatar Apr 21 '24 14:04 Finii

@Finii

I've put up a pull request to add @FrancescoLuzzi! :tada:

allcontributors[bot] avatar Apr 21 '24 14:04 allcontributors[bot]

Oh! == is don't work, or my computer have problem?

nguyenlephuc2108 avatar Jul 25 '24 12:07 nguyenlephuc2108