clean-code-javascript icon indicating copy to clipboard operation
clean-code-javascript copied to clipboard

Improve example code demonstrating Interface Segregation Principle.

Open cpressey opened this issue 2 years ago • 0 comments

Hello. This is a useful resource.

When reading the section on the Interface Segregation Principle it occurred to me that the code section could give a stronger and clearer example. The principle is "Clients should not be forced to depend upon interfaces that they do not use." Even knowing about the existence is a dependency, and it can be avoided in this case. There is no reason for the client code to even know that animationModule exists or that DOMTraverser cares about it.

(This sort of thing happens frequently in practice; e.g. if animationModule is added to a new version of DOMTraverser, old client code will not know about it, and making it optional in this way avoids having to update those calls.)

cpressey avatar Feb 20 '22 19:02 cpressey