unotes icon indicating copy to clipboard operation
unotes copied to clipboard

Published 20 hours ago • verified publisher icon ryanmcalister

Feature Implemented (Prevent image duplication when dragging and dropping image files in the media folder. #133)

Open kiyoka opened this issue 2 years ago • 3 comments

Feature Implemented. This makes local file handling more convenient.

Unotes version: 1.4.3

Description

  • Fixes #133
  • Fixes #93
  • Dragging and dropping images in the media folder does not duplicate the images.
  • Selecting an image in the media folder from the toolbar does not duplicate the image.
  • Image files under the media folder are not duplicated even in deep hierarchies.
  • Supported Windows style path and Windows style separator '\'.
  • Supported Windows drive letters.

Tested

  • Tested only on Windows 10 Pro.
  • Tested with and without drive letter in path.
  • Tested the case where the media folder setting is a relative path.
  • Tested the case where the media folder setting is an absolute path.

Not tested

  • Not tested on macOS.
  • Not tested on Linux.

If you have one of these unix path style environments, please check that it works.

kiyoka avatar Aug 16 '22 10:08 kiyoka

Looks good. Just ran into one issue testing on Linux.

ryanmcalister avatar Aug 18 '22 20:08 ryanmcalister

What kind of issue is it? Let me know and I will fix it. I will also be installing an Ubuntu 22 environment.

kiyoka avatar Aug 24 '22 12:08 kiyoka

What kind of issue is it? Let me know and I will fix it. I will also be installing an Ubuntu 22 environment.

Sorry, I forgot to finish submitting the review. See the comments in the code review.

ryanmcalister avatar Aug 24 '22 15:08 ryanmcalister

@ryanmcalister Fixed path handling bug. Please review again.

kiyoka avatar Aug 27 '22 07:08 kiyoka