Ryan Linton
Ryan Linton
This bit us today on IR website. I'll try to take a crack at fixing later.
@yulolimum https://github.com/infinitered/thesis-phoenix/pull/107 added support for custom html editors. We could still switch the default editor if we want. I was wondering if it wouldn't make sense to wrap up what...
> Could we document what the magic numbers are doing? Maybe pull them out into constants? @NickGerleman I pulled out the color space and component ratios definitions into constants. Should...
@cipolleschi Thanks! That worked after I also updated React-graphics to only pull in React-jsi instead of all of React-Core.
@NickGerleman I dropped the bridge changes to keep this completely focused on MapBuffer.
Hi @cortinico! Please assign [react/uimanager/UIManagerModuleConstantsHelperTest.java](https://github.com/facebook/react-native/tree/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/UIManagerModuleConstantsHelperTest.java) to me.
@NickGerleman Good to know. What do you think about something like `Platform.is('ios')` that just wraps the `Platform.OS` condition? That could use `PlatformOSType` for now and would still read similar. Not...
@motiz88 > My main question here is "why?" What does this achieve from a user's perspective that Platform.OS === 'ios' doesn't? In terms of functionality it doesn't accomplish anything new....
Opened an [RFC](https://github.com/react-native-community/discussions-and-proposals/pull/670).
I just tried adding the following test: ``` js test('link-to test', function(){ compilesTo("| #{link-to 'aroute' | Some Text}", "{{link-to 'aroute'}}Some Text{{/link-to}}"); }); ``` and got: ``` js 229) text: pipe...