skip-thoughts icon indicating copy to clipboard operation
skip-thoughts copied to clipboard

Published 20 hours ago • verified publisher icon ryankiros

gru_layer code different from paper

Open zengzhaoyang opened this issue 7 years ago • 1 comments

image image The code snippet in "training/layers.py" and "skipthoughts.py" doesn't match the formulas in the paper, should it be modified as

preactx = tensor.dot(h_ * r, Ux)
preactx = preactx + xx_

zengzhaoyang avatar Mar 17 '17 12:03 zengzhaoyang

@zengzhaoyang Hi,

I also found this problem when I read the code. Is there a conclusion now? Thanks.

CZWin32768 avatar Mar 27 '18 05:03 CZWin32768