Gyeongjae Choi
Gyeongjae Choi
Yep, I would like to refactor the micropip (#112) before introducing large changes like `resolvelib` or `installer` or PEP 658 (FYI, there is a draft PR for PEP 658 #90)....
@sbc100, May I ask for your review again when you have time?
> @ryanking13 I'm curious about the different between this patch and https://github.com/emscripten-core/emscripten/pull/25694. Do they both solve the same issue? Do you have a preference for one over the other? @sbc100...
@sbc100 > Would this also fix https://github.com/emscripten-core/emscripten/issues/25814? Unfortunately no, I tested the worker case but I get fiile not found error. Does `--embed-file` parameter work differently in worker?
@sbc100 > To get the codesize expectations to match you need to run toosl/main/rebaseline_test.py after first doing emsdk install tot. If you have having trouble doing that let me know...
> Another possible way for programmers to extend/override functionality could be to offer overridable methods, e.g.: Sounds reasonable to me. I am not a big fan of Mixins, but subclassing...
@RulerOfCakes This can be an interesting work if you are interested.
> Sure, I'm interested 👀 I'll see what I can do.. Thanks! I think we can start with defining `micropip.Client` (or Manager? Micropip? I am always not sure about the...
> I guess I have sort of an unrealistic expectation here: that micropip solves the dependencies in exactly the same way as pip. But even if that's not the case...
@alexmojaki > Is this essentially the same problem? Not actually I guess, but it is something we need to fix too.