Gyeongjae Choi comments

Results 674 comments of


                                            Gyeongjae Choi

Type definition of `PyodideInterface.FS` is wrong

Thanks for the report @whitphx. I agree we should improve the type definition, but as Emscripten is written in JS, and [DefinitelyTypes/Emscripten](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/emscripten) is a bit outdated, so it is difficult...

Type definition of `PyodideInterface.FS` is wrong

We recently adopted DefinitelyTyped/Emscripten for FS type, thanks to @R3gardless. So the IDEs should be able to use types from DefinitelyTyped/Emscripten.

Fix builds for `libgmp` when building on macOS

> I'm not sure if setting HOST_CC is correct this way, as it is not necessary that Clang may exist on a Linux machine by default (hence this is only...

Fix builds for `libgmp` when building on macOS

Let's reopen this in pyodide-recipes when ready.

Error message for unexpected url scheme does not make sense

> Can we say "Unexpected URL scheme" here? Yes, that sounds better to me.

Support `formats` option in sdl2 mixer

I added some tests, but it seems like FROZEN_CACHE is not happy with sdl2_mixer variants, hmm...

[Feature Rquest] Option to make a new canvas for every plt.show()

`pyplot.show()` does not accept any parameters. So instead of patching `show`, I would recommend to save the figure (`plt.savefig`) then put it to the place you want, which is more...

[Feature Rquest] Option to make a new canvas for every plt.show()

Unfortunately, we lack human resources to maintain this package (see: #65). Feel free to fork the project and add features you need. But I don't think we can implement this...

Update pygame-ce to 2.5.3

Yes, will do. Please disable it for now.

Use of vite-plugin-static-copy NPM package with exclude patterns for Vite bundling example

> I'm happy to do a PR to the docs to show this use of vite-plugin-static-copy if you think it's a better approach. So far it's working well for me....