Ryan Baxter comments

Results 639 comments of


                                            Ryan Baxter

Consider Testcontainers (Localstack) to replace Mockito for AWS integrations

Sound interesting! If you want to take a go at implementing it we can take a look!

Consider Testcontainers (Localstack) to replace Mockito for AWS integrations

Can you separate out the tests from that PR into a new PR?

Consider Testcontainers (Localstack) to replace Mockito for AWS integrations

@MatejNedic thats fine

Bitbucket V2 Git Protocol Not Working

Thanks @tomaswolf Related to https://github.com/spring-cloud/spring-cloud-config/issues/1901

Spring cloud config server on refresh -> logback config also refresh automatically

So is the event handler not called? Logging is reinitialized when a refresh event is received.

Spring cloud config server on refresh -> logback config also refresh automatically

Are you upgrading from a previous version of Spring Cloud that caused a change in behavior?

Spring cloud config server on refresh -> logback config also refresh automatically

>To my surprise, I don't need to do it anymore So you are saying this is a chance in behavior from Finchley.RELEASE? What release are you trying now?

Spring cloud config server on refresh -> logback config also refresh automatically

I am really lost on how the behavior changed if you did not change the Spring Cloud version. Maybe I am not understanding you. I can't point you to any...

Spring cloud config server on refresh -> logback config also refresh automatically

Refresh events will restart the application context so logging will be reinitialized I believe

Spring cloud config server on refresh -> logback config also refresh automatically

I think the most relevant documentation might be here https://docs.spring.io/spring-cloud-commons/docs/current/reference/html/#environment-changes