Ryan Baxter

Results 639 comments of Ryan Baxter

Probably need to debug here to start https://github.com/spring-cloud/spring-cloud-config/blob/4841d800951a52aba4add1e856bdf7a6e7421291/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/composite/CompositeEnvironmentBeanFactoryPostProcessor.java#L51 Let me know if you have time to take a look. If not I will put it on my list

Interested to hear your thoughts about what we will need to do to support this.

Are you using Resilience4J annotations and that is why you need `spring-boot-starter-aop`? https://resilience4j.readme.io/docs/getting-started-3#annotations

That is not functionality provided by Spring Cloud CircuitBreaker not Spring Cloud OpenFeign the requirement is coming from Resilience4J. So I do not believe we should be including the AOP...

Are you referring to this functionality? https://docs.spring.io/spring-cloud-kubernetes/reference/spring-cloud-kubernetes-configuration-watcher.html#_monitoring_configmaps_and_secrets

I think that would be a worthwhile enhancement we can look into. Right now we use the `DiscoveryClient` to go through and notify the application and that works on the...

Thanks for the initial feedback. Couple of thoughts. 1.) I assume if you disable labels via `metadata.add-labels` you probably shouldn't use labels as a way of notifying the apps ;)....

Please provide a sample that reproduces the error with a supported release (4.1.x or greater).

A concrete sample that reproduces your use case would help here to make sure we are on the same page. It sounds like what you are suggesting is that AWS...

OK this is what I thought, this would be a worthwhile enhancement