Ryan Baxter

Results 639 comments of Ryan Baxter

3.1.x is not actually a major for us so there cannot be breaking changes in main. However this is a big enough change it seems that we should keep it...

I thought everything was wrapped in a feature flag and it wasn't introducing any breaking changes. If that is not the case then it will need to wait and cannot...

LGTM once you are satisfied with it we can merge it into main.

But it still needs a major? Also the DCO check needs to pass

Can you also provide your configmaps?

I dont think this is correct ``` sources: - name: test.message ``` That is the data in your config map. The `sources.name` property should be the name of the config...

See my comment here I think that might help https://github.com/spring-cloud/spring-cloud-kubernetes/issues/1666#issuecomment-2179405315

I think we would need to make the configuration a bit more robust if we are configure things via properties in the watcher itself. Something like this would make more...

I believe when I first wrote this feature that there was a maximum amount of time it could take before the mounted file was updated. Anything under that time was...