Ryan Baxter

Results 639 comments of Ryan Baxter

This method is still present in the latest release https://github.com/spring-cloud/spring-cloud-config/blob/v3.1.4/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/environment/EnvironmentController.java#L109

This goes back to what I said above > In the context of git, svn, or file based repositories we get this functionality via Boot's config data functionality which is...

When I run this integration test, modified with ``` spring: cloud: kubernetes: discovery: all-namespaces: true ``` I get services from all namespaces. https://github.com/spring-cloud/spring-cloud-kubernetes/tree/2.1.x/spring-cloud-kubernetes-integration-tests/discovery/kubernetes-client-discovery

Should we be returning endpoints across all namespaces or should that be enabled via a property, kind of like service discovery?

So its only when `all-namespaces` is `true` that we run into this issue then?

If so I think we should make the breaking change. I would just make it in #1138

Ok makes sense. Let's make the change to a tuple in your PR

I think maybe the best solution would be to just set the name to be `` as that is what the label is in k8s.

If you could try Spring Cloud 2021.0.8-SNAPSHOT we have made some changes regarding profiles and activation. See https://docs.spring.io/spring-cloud-commons/docs/3.1.7-SNAPSHOT/reference/html/#application-context-hierarchies

@dantonyuk sorry for not getting to this sooner. One question I have is what happens if no label is provided and no default label is set. I tried to look...