Ryan Baxter comments

Results 639 comments of


                                            Ryan Baxter

Add null checks for org.springframework.boot.autoconfigure.web.ServerProperties.Servlet#getContextPath()

Ping @candrews, could you add a test?

Add null checks for org.springframework.boot.autoconfigure.web.ServerProperties.Servlet#getContextPath()

Ping @candrews care to continue working on this PR?

x-forwarded-proto appended in zuul (should be replaced)

I read through the Spring Boot issue and it just seemed like he made a request with a `x-forwarded-poto` header to zuul and zuul tacked on the same value to...

Eureka initial status should be Starting

So does it then become the developers responsibility to set the status to `UP`?

Eureka initial status should be Starting

I thought it was the heartbeat that determined whether an app was `UP` by default. If actuator is on the path and you set ``` eureka: client: healthcheck: enabled: true...

Eureka Clustering documentation and best practices

+1 adding additional documentation around how to configure this would be helpful

Update Eureka client status URL based on SSL configuration

Can you show us the configuration that you think should work?

Update Eureka client status URL based on SSL configuration

Is that all of the configuration? Shouldnt you also be enabling SSL via Spring Boot configuration?

Update Eureka client status URL based on SSL configuration

Looks like your configuration is a little off, it should be ``` eureka: instance: nonSecurePortEnabled: false hostname: 172.25.1.2 prefer-ip-address: false securePortEnabled: true secure-port: ${server.port} client: service-url: defaultZone: https://localhost:8761/eureka ``` As...

Update Eureka client status URL based on SSL configuration

I am going off what our documentation states about [registering secure applications](http://cloud.spring.io/spring-cloud-static/Camden.SR6/#_registering_a_secure_application). I would stick with what the documentation states. We dont have any plans that I know of to...