review-obsidian icon indicating copy to clipboard operation
review-obsidian copied to clipboard

Suggestion / request: Adding predefined date patterns

Open 5toliv opened this issue 4 years ago • 11 comments

Hi @ryanjamurphy ! All right?

Your plugin is fantastic! It addresses a need for students to maintain a continuous and effective flow of reviews. I am grateful for this!

I have a suggestion / request: For us exam students, the reviews already have defined periods. Ex.: High incidence subjects: 3 - 20 - 45 - 60 days; and Low incidence subjects: 4 - 30 - 60 - 90 days.

Would it be possible to add some template or configuration to make it possible to include revisions for previously defined days?

Thus, there would be no concern in defining date by date.

Exemple: image

#enhancement

5toliv avatar Nov 06 '20 11:11 5toliv

Great suggestion, thanks! This would also be valuable for e.g., repeating tasks.

I'd love to implement it, and I think it should be easy. I will see what I can do.

ryanjamurphy avatar Nov 06 '20 18:11 ryanjamurphy

Great suggestion, thanks! This would also be valuable for e.g., repeating tasks.

I'd love to implement it, and I think it should be easy. I will see what I can do.

This would be fantastic!

From now on, my many thanks!

5toliv avatar Nov 06 '20 19:11 5toliv

Hi @ryanjamurphy ! All right?

Your plugin is fantastic! It addresses a need for students to maintain a continuous and effective flow of reviews. I am grateful for this!

I have a suggestion / request: For us exam students, the reviews already have defined periods. Ex.: High incidence subjects: 3 - 20 - 45 - 60 days; and Low incidence subjects: 4 - 30 - 60 - 90 days.

Would it be possible to add some template or configuration to make it possible to include revisions for previously defined days?

Thus, there would be no concern in defining date by date.

#enhancement

image

5toliv avatar Nov 06 '20 22:11 5toliv

Thanks for this. I think I'd go simpler, though. A syntax like:

Review pattern Pattern
high incidence 1 3 5 10 20 40

where each numeral indicates the number of days to add to today to add a review note.

Mostly because this'd be far easier to code, heh.

ryanjamurphy avatar Nov 06 '20 22:11 ryanjamurphy

Much more direct and practical! Hahaha Grateful for the attention and response!

5toliv avatar Nov 07 '20 02:11 5toliv

I was just thinking about a custom default date. E.g. Monday because the default tomorrow doesn't actually work. Maybe the two ideas are related?

Nebucatnetzer avatar Nov 09 '20 21:11 Nebucatnetzer

I was just thinking about a custom default date. E.g. Monday because the default tomorrow doesn't actually work. Maybe the two ideas are related?

@Nebucatnetzer Do you mean for this plugin (Review), or for the Natural Language Dates plugin?

If you mean for Review, how do you imagine this would work? A "default review" command, maybe, such that instead of prompting with a modal it just assigns the current note to a preset number of days in the future or the past?

ryanjamurphy avatar Nov 10 '20 15:11 ryanjamurphy

For this plugin. I thought it might work like this:

  1. Configure a default date in the settings e.g. "monday".
  2. Go to a note.
  3. Start the review command.
  4. Don't enter anything and press enter.
  5. Review then uses the default date from the settings.

If the user enters something in the input field Review then uses the date from the input.

Nebucatnetzer avatar Nov 10 '20 21:11 Nebucatnetzer

Ah, neat. Makes sense to me—I'mma try to convert this into a new issue though, to keep things atomic!

ryanjamurphy avatar Nov 10 '20 21:11 ryanjamurphy

Just a quick update on this front. What I need to figure out is how to easily and elegantly allow the user to add and remove an arbitrary number of patterns.

This is a bit tricky, because each new pattern would, ideally, also be a new in-app command (so that you don't need to jump through multiple modals or something to invoke a new pattern.

It should be doable, I just haven't had the chance to figure it out yet!

ryanjamurphy avatar Nov 16 '20 22:11 ryanjamurphy