quicksilver icon indicating copy to clipboard operation
quicksilver copied to clipboard

Deprecate stdweb and migrate to web-sys

Open ryanisaacg opened this issue 3 years ago • 4 comments

Rationale: Unfortunately, stdweb has been going unmaintained (as has its sister project, cargo-web.) web-sys and wasm-bindgen have more than reached parity with stdweb, and progress on tooling to match cargo-web is going well. Contributions to upstream projects like winit are increasingly web-sys only, so the pressure is there to remove stdweb support.

To make web-sys the default or remove stdweb entirely, we need to:

  • [ ] Document a new workflow (#652)
  • [ ] Add a warning when compiling under stdweb
  • [ ] Document any issues this causes (in this issue)
  • [ ] Contribute a stdweb to web-sys transition to gilrs

Please feel free to reply with any issues you encounter with moving to web-sys for Quicksilver projects.

ryanisaacg avatar Sep 08 '20 20:09 ryanisaacg

👍 I've stopped maintaining stdweb in https://github.com/johnpmayer/quicksilver-utils

I have a not-too-large, but complete and documented example that should run with web-sys.

https://github.com/johnpmayer/quicksilver-utils/tree/master/examples/project

johnpmayer avatar Sep 08 '20 21:09 johnpmayer

FWIW, I was able to get quicksilver 0.3 compiling with wasm-bindgen/wasm-pack, I just needed to add a patch section to Cargo.toml for stdweb to this branch.

coolreader18 avatar Oct 26 '20 18:10 coolreader18

[patch.crates-io]
stdweb = { git = "https://github.com/coolreader18/stdweb", rev = "ccc453c653bbcc4a20e7a1dd3ce884b626d5e7e7" }

coolreader18 avatar Oct 26 '20 18:10 coolreader18

https://gitlab.com/gilrs-project/gilrs/-/merge_requests/51 Edit: merged

coolreader18 avatar Oct 27 '20 00:10 coolreader18