golem icon indicating copy to clipboard operation
golem copied to clipboard

Glow now requires a reference to uniform location

Open PvdBerg1998 opened this issue 4 years ago • 3 comments

Fixes #32

PvdBerg1998 avatar Jul 03 '20 14:07 PvdBerg1998

I'd recommend upgrading to 0.5, as there's only one other API change in there compared to 0.4.1. That way, you're not going to run into problems if glow yanks the dodgy 0.4 version.

EDIT: aaaand it's yanked :)

17cupsofcoffee avatar Jul 03 '20 14:07 17cupsofcoffee

I've updated to glow 0.5, but the examples are not compiling at the moment because blinds is still on glow 0.4.

Edit: this should be checked for correctness as I'm definitely not knowledgeable in either of these crates.

PvdBerg1998 avatar Jul 03 '20 14:07 PvdBerg1998

This exposes an issue that's sort of significant: every single glow breaking change is a breaking change for blinds and golem. It might be better to figure out a more-stable way of creating and managing the GL context.

Because this change isn't very urgent, I would say it might be best to hold off on bumping the glow version until this question is resolved.

ryanisaacg avatar Jul 03 '20 23:07 ryanisaacg