just_audio icon indicating copy to clipboard operation
just_audio copied to clipboard
verified publisher icon ryanheise

feat(LockCachingAudioSource): add network error handling

Open danielgomezriconeon opened this issue 11 months ago • 7 comments

Try to fix:

  • #1213
  • #594

Done:

  • Add retry mechanism for _fetch
  • Do not throw exceptions on query but return Future with errors so caller could handle them gracefully

danielgomezriconeon avatar Jan 29 '25 16:01 danielgomezriconeon

@ryanheise I'm having troubles trying to test multiple scenarios, can you please give me a hint?

I added a retry logic on the fetch method, but that's running without awaiting it.

And for some reason, if an exception is thrown there or the future returns an error, it is not being propagated to the main await, where: https://github.com/ryanheise/just_audio/pull/1398/files#diff-1425e2b963b2b8d4c9fde51b8fabf85b624477e9373c365a72bea2aa6071990bR137-R143

danielgomezriconeon avatar Feb 07 '25 15:02 danielgomezriconeon

@ryanheise ping :)

danielgomezriconeon avatar Mar 05 '25 14:03 danielgomezriconeon

Hi, I'm just working on getting the next major release out, but if I haven't returned to this within a week, please feel free to send another ping.

ryanheise avatar Mar 11 '25 14:03 ryanheise

@ryanheise ping :)

danielgomezrico avatar Mar 24 '25 14:03 danielgomezrico

New ping :)

nateshmbhat avatar Apr 22 '25 04:04 nateshmbhat

It seems that this was deprecated, I will test the new API image

danielgomezriconeon avatar May 02 '25 14:05 danielgomezriconeon

It looks like all of the error handling implemented here is already handled in the latest update, just this one is still missing:

  • https://github.com/ryanheise/just_audio/issues/1469

danielgomezriconeon avatar May 13 '25 15:05 danielgomezriconeon